#2 Patch to jde-eclipse-compiler-server.el

closed-accepted
nobody
None
5
2010-04-30
2007-12-31
Paul Kinnucan
No

Yee Keat Phuah [ykphuah@gmail.com]:

After understanding more about the problems that I was facing previously while using jde-eclipse-compiler-server, realized that the hack it does to the comint-mode might be causing the problem. I have reverted to use the one-invocation-per-flymake method, which is documented as the first way to use jde-eclipse-compiler-server with flymake in the source file.

There's a bug in the first method though, the classpath is not passed into the ecj.jar correctly, here's a patch that fixed it for me:

--- jde-eclipse-compiler-server.el.orig 2007-12-10 09:43:51.101262700 +0800
+++ jde-eclipse-compiler-server.el 2007-12-10 09:44:58.840156000 +0800
@@ -431,8 +431,8 @@
(local-file (file-relative-name
temp-file
(file-name-directory buffer-file-name))))
- (list "java" (append (jde-compile-classpath-arg (jde-compile-get-the-compiler))
- (list "-jar" (oref (jde-compile-get-ejc) path) "-Xemacs")
+ (list "java" (append (list "-jar" (oref (jde-compile-get-ejc) path) "-Xemacs")
+ (jde-compile-classpath-arg (jde-compile-get-the-compiler))
jde-ecj-command-line-args
(list local-file))))))

Discussion

  • Len Trigg
    Len Trigg
    2010-04-30

    • status: open --> closed-accepted
     
  • Len Trigg
    Len Trigg
    2010-04-30

    Applied to the jdee integrated version of ecj flymake.