#24 jde-xref-get-db-directory fails with nested prj.el

closed-accepted
nobody
5
2011-06-10
2011-01-10
Troy Daniels
No

jde-xref-get-db-directory normalizes the path by just passing the value of the db directory. This gives the incorrect result when there are multiple prj.el files and the one defining the variable is not the deepest. The implementation should be

(concat (jde-normalize-path 'jde-xref-db-base-directory) "/xrefdb"))

instead of

(concat (jde-normalize-path jde-xref-db-base-directory) "/xrefdb"))

(Note that jde-xref-db-base-directory is quoted in the correct implementation.

Discussion

  • Troy Daniels
    Troy Daniels
    2011-01-10

    There is a similar issue with with-all-class-files. About 20 lines in, it wants to be

    (let ((,normalized-path-sym (jde-normalize-path ,path-sym 'jde-built-class-path)))

    not

    (let ((,normalized-path-sym (jde-normalize-path ,path-sym)))

     
  • Len Trigg
    Len Trigg
    2011-06-10

    • status: open --> closed-accepted
     
  • Len Trigg
    Len Trigg
    2011-06-10

    Fix applied in SVN.