From: Morten O. A. <mor...@gm...> - 2011-08-23 18:19:11
|
On 22 August 2011 23:02, Olly <ol...@us...> wrote: > Hi, > > I commited to trunk an updated version of patch 3313564 > ("GroupSelector patch") by Andreas Schlicker. > > GroupSelector is modified to ease adding/removing references to/from groups. > > A new toggle button "Invert Group Membership Mode" is added. If the > button is "on", the functionality is activated. If it is "off", the > Group Selector behaves as normal. > > The changed functionality is: > In case of the click to a group the membership of the selected entries > is toggled: All entries in the group are removed from the group and > vice versa. > > Maybe a better label would be "Toggle Group Membership Mode", but > since it's a toggle button, I opted for "Invert ..." > > > What do you think about that functionality? Can we keep it in JabRef > or should we try to make that button optional? I think the feature is good, but it's a little non-obvious (it needs a better tooltip description), and because of that I feel that this button is too prominent in the interface - also the button has a fairly significant effect, and it may not be obvious to a user what consequences a couple of clicks can have when the button is activated. Since this is (as far as I know) the only toggle button in the entire application, it may not even be obvious to users that it is activated. I think it would be better to change it into a check box menu item in the Settings menu, perhaps along with a visual cue that this mode is activated - something like a different background color in the group tree? Morten |