Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#73 Support odd powers of two for QAM

Next_Release
accepted
itpp (51)
5
2014-02-22
2010-09-25
Kumar Appaiah
No

Hi!

My work requires me to use odd powers of two for the QAM class. However, IT++ does not yet have support for this. Please add support for this.

I have attached a rudimentary patch to get this done. I would be more than happy to adapt it for:

  • handling checks I may have missed
  • coding style
  • tests

Please let me know how I can be of help.

Thanks!

Kumar

Discussion

  • Kumar Appaiah
    Kumar Appaiah
    2010-10-04

    Gentle ping: could someone please review this?

    Thanks in advance, and sorry for bugging. :-)

     
  • Kumar Appaiah
    Kumar Appaiah
    2011-04-15

    Is there any update to this? I've run into this problem again on another machine, and I need to manually patch IT++ to fix it.

    This isn't such a difficult patch to review, I'd appreciate it if someone could have a look at it and comment.

    Thanks!

    Kmar

     
  • Bogdan Cristea
    Bogdan Cristea
    2013-05-23

    Is there any interest in this feature ? I can handle the integration, but I don't have time for implementation details.

     
  • Kumar Appaiah
    Kumar Appaiah
    2013-05-23

    I am still interested in this, but I might not be able to finish it by the release target date. Given that this is the case, please set this for the next milestone, and not the release you are planning this week.

    I'll integrate it as soon as the release is done.

    Thanks.

     
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-16

    • status: open --> accepted
    • assigned_to: Bogdan Cristea
    • Group: --> Next_Release
     
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-16

    Changes committed into master branch; Thanks Kumar.

     
  • Kumar Appaiah
    Kumar Appaiah
    2014-02-20

    Heh. And I misspelt the word energy in the commit. Urgh! Please fix that as well! Thanks.

     
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-22

    done