#238 Bugs found during Mac OS X compilation

release_4.3.x
accepted
None
1
2014-02-11
2014-02-07
andy_panov
No

Please find attached diff fixing issues found by Sea Woods during the OS X compilation
Here is the brief summary:
1. Typos fixed if audiofile.cpp, audiosample.h
2. return type of isnan, isfinite, isinf changed to bool to make it compatible with latest C++ standard.

1 Attachments

Discussion

1 2 > >> (Page 1 of 2)
  • andy_panov
    andy_panov
    2014-02-07

    Bugfix for pnm.cpp added. Patch updated.

     
    Attachments
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-09

    • assigned_to: Bogdan Cristea
    • Group: release_2.3.x --> release_4.3.x
     
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-09

    Changes committed into master branch. Unit tests don't pass on MacOsX 10.9. All tests pass on openSUSE 13.1 64 bits. No compilation warning is generated on both systems.

     
  • andy_panov
    andy_panov
    2014-02-09

    Hi Bogdan,

    I can confirm that test code runs smoothly on Windows.

    I am trying to debug the complex number extraction issue here with the help of Sea Woods

    Andy.

     
    Last edit: andy_panov 2014-02-09
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-09

    Hi Andy
    Thank you for your contributions. Please let me know if I can help.
    regards
    Bogdan

     
  • andy_panov
    andy_panov
    2014-02-10

    Hi Bogdan,

    Can we switch to libstdc++ on OS X? libc++ streams are broken (please see my latest post in Help thread). In order to make itpp running on Mac OS we need to add --stdlib=libstdc++ option to compile flags. Could you please look into it? I am not a cmake guru and have no idea how to fix this. More to say, I do not even have a Mac OS available.

    Andy.

     
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-10

    • status: open --> accepted
     
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-10

    Hi
    I have just committed a patch for allowing compilation on MacOsX 10.9. All tests pass. However, in the long term we should ensure compatibility with libc++, because it is the default library used by clang compiler.
    regards
    Bogdan

     
  • andy_panov
    andy_panov
    2014-02-11

    Here is the patch to remove the redundant instantiations in freq_filt.cpp

     
    Attachments
  • Bogdan Cristea
    Bogdan Cristea
    2014-02-11

    Changes committed into master branch. Tests pass on openSUSE 13.1 and MacOsX 10.9. Thank you Andy for providing the patches.

     
1 2 > >> (Page 1 of 2)