Menu

#5 PDU logfiles are not getting placed inside LogFiles folder

v1.0_(example)
closed
nobody
None
5
2016-07-20
2015-07-06
No

Hi David,

In Linux, PDU logfiles are not getting placed in LogFiles folder instead logfile gets created inside src as below with name containing 'LogFiles'

:~/iscsisim/src$
-rw-r--r-- 1 root root 246 Jul 6 16:25 LogFiles\20150706_1625_3.log
-rw-r--r-- 1 root root 0 Jul 6 22:06 LogFiles\20150706_2206_1.log
-rw-r--r-- 1 root root 0 Jul 6 22:07 LogFiles\20150706_2207_4.log
-rw-r--r-- 1 root root 244 Jul 6 22:12 LogFiles\20150706_2208_0.log
-rw-r--r-- 1 root root 3763 Jul 6 23:32 LogFiles\20150706_2328_56.log
-rw-r--r-- 1 root root 3763 Jul 6 23:35 LogFiles\20150706_2335_10.log
-rw-r--r-- 1 root root 3763 Jul 6 23:35 LogFiles\20150706_2335_28.log
-rw-r--r-- 1 root root 1862 Jul 6 23:36 LogFiles\20150706_2336_25.log
-rw-r--r-- 1 root root 1862 Jul 6 23:44 LogFiles\20150706_2338_33.log

This issue is because of path separator being different on windows and linux.

I have fixed this issue and attached patch for same here.
Let me know if I can commit this patch.

Thanks.
Devendra

1 Attachments

Related

Bugs: #5

Discussion

  • David Cuddihy

    David Cuddihy - 2015-07-07

    The patch looks fine, and works on Windows as well. Go ahead and commit it. I've added you as developer to this project.

    I'm afraid this hasn't been tested on linux - you might run into a number of file system and/or capitalization issues. Feel free to let me know what you see.

    Thank you for the excellent bug ticket and patch.

    David

     
  • Devendra Tapdia

    Devendra Tapdia - 2015-07-08

    Thanks David for adding me as developer.

    As you have mentioned, I have updated above patch with issues for ITD, PDU, Binaries file paths. These changes complete all file path issues on linux.

    I have attached updated patch here. You can review it once.

    Thanks,
    Devendra

     
  • Devendra Tapdia

    Devendra Tapdia - 2015-07-14

    These changes works on both linux and windows. I have committed these changes.

     

    Last edit: Devendra Tapdia 2015-07-14
  • David Cuddihy

    David Cuddihy - 2015-07-14
    • status: open --> pending
     
    • Devendra Tapdia

      Devendra Tapdia - 2015-07-24

      Hi David,

      We can close the ticket #5.

      Thanks.
      Devendra

      On Wed, Jul 15, 2015 at 2:00 AM, David Cuddihy davidcuddihy@users.sf.net
      wrote:

      • status: open --> pending

      Status: pending
      Group: v1.0_(example)
      Created: Mon Jul 06, 2015 07:50 PM UTC by Devendra Tapdia
      Last Updated: Tue Jul 14, 2015 02:13 PM UTC
      Owner: nobody

      Hi David,

      In Linux, PDU logfiles are not getting placed in LogFiles folder instead
      logfile gets created inside src as below with name containing 'LogFiles'

      :~/iscsisim/src$
      -rw-r--r-- 1 root root 246 Jul 6 16:25 LogFiles\20150706_1625_3.log
      -rw-r--r-- 1 root root 0 Jul 6 22:06 LogFiles\20150706_2206_1.log
      -rw-r--r-- 1 root root 0 Jul 6 22:07 LogFiles\20150706_2207_4.log
      -rw-r--r-- 1 root root 244 Jul 6 22:12 LogFiles\20150706_2208_0.log
      -rw-r--r-- 1 root root 3763 Jul 6 23:32 LogFiles\20150706_2328_56.log
      -rw-r--r-- 1 root root 3763 Jul 6 23:35 LogFiles\20150706_2335_10.log
      -rw-r--r-- 1 root root 3763 Jul 6 23:35 LogFiles\20150706_2335_28.log
      -rw-r--r-- 1 root root 1862 Jul 6 23:36 LogFiles\20150706_2336_25.log
      -rw-r--r-- 1 root root 1862 Jul 6 23:44 LogFiles\20150706_2338_33.log

      This issue is because of path separator being different on windows and
      linux.

      I have fixed this issue and attached patch for same here.
      Let me know if I can commit this patch.

      Thanks.
      Devendra


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/iscsisim/bugs/5/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

      Related

      Bugs: #5


      Last edit: Devendra Tapdia 2015-08-09
  • David Cuddihy

    David Cuddihy - 2016-07-20
    • status: pending --> closed
     

Log in to post a comment.