Thread: Re: [Ipsec-tools-devel] [PATCH] racoon 0.8: remove unnecessary function call from reload
Brought to you by:
mit_warlord,
netbsd
From: Roman H. A. <rh...@op...> - 2011-01-26 13:10:30
|
Hi Timo As discussed, I send the cleanup patches for the reload functions (rmconf_tmp.patch, rmconf.patch). I additionally renamed the sainfotree functions (sainfo.patch), as they are being used only during reload. I could not resist, as I saw the similarity with rmconf. If you dislike it, just ignore it. The same localization as for rmconf_tmp can be done for sitree_tmp (sainfo_tmp.patch). I left the save_params and restore_params functions as they were, because they are used earlier during program startup in session.c. The patch files work best if applied in this order: 1. rmconf_tmp.patch 2. rmconf.patch 3. sainfo.patch 4. sainfo_tmp.patch Regards, Roman |
From: Timo T. <tim...@ik...> - 2011-01-28 13:05:02
|
Hi Roman, On 01/26/2011 03:10 PM, Roman Hoog Antink wrote: > As discussed, I send the cleanup patches for the reload functions > (rmconf_tmp.patch, rmconf.patch). > > I additionally renamed the sainfotree functions (sainfo.patch), as they > are being used only during reload. I could not resist, as I saw the > similarity with rmconf. If you dislike it, just ignore it. > > The same localization as for rmconf_tmp can be done for sitree_tmp > (sainfo_tmp.patch). > > I left the save_params and restore_params functions as they were, > because they are used earlier during program startup in session.c. > > The patch files work best if applied in this order: > 1. rmconf_tmp.patch > 2. rmconf.patch > 3. sainfo.patch > 4. sainfo_tmp.patch I've committed all these now (with the change of removing 'static' from the local temp variable definition since that won't be needed). I also committed the remote IP logging patch with additional edits. Thanks, Timo |