Re: [Ipmitool-devel] Regarding Retries/Timeout for LAN/LANPLUS interface

[Zdenek S. <zde...@gm...>]

On Mon, Oct 10, 2011 at 5:32 PM, Harshad Prabhu (hprabhu)
<hp...@ci...> wrote:
[...]
> +        /* Retry and Timeout */
> +       case 'R':
> +           retry = (uint8_t)strtol(optarg, NULL, 0);
> +           break;
> +        case 'N':
> +            timeout = (uint8_t)strtol(optarg, NULL, 0);
> +            break;

Hello,

it seems you're not worried it is possible to overflow `retry' and
`timeout' which will lead to unexpected behavior.

Regards,
Zdenek