#304 Incorrect byteswap in SOL maximum payload code

version-1.8.14
closed-fixed
None
5
2014-04-12
2014-04-12
Anton Blanchard
No

max_inbound_payload_size, max_outbound_payload_size and port are
assembled byte by byte using shifts. This works correctly in both
little and big endian and doing a subsequent byte swap is wrong.

To highlight this issue I dumped the values on a big endian machine:

max_inbound_payload_size 51200
max_outbound_payload_size 51200
port 28418

And after this fix:

max_inbound_payload_size 200
max_outbound_payload_size 200
port 623

1 Attachments

Discussion

  • Zdenek Styblik
    Zdenek Styblik
    2014-04-12

    Committed into Git.

     
  • Zdenek Styblik
    Zdenek Styblik
    2014-04-12

    • status: open --> closed-fixed
    • assigned_to: Zdenek Styblik
    • Group: version-1.8.15 --> version-1.8.14