From: Niko Kiirala <niko@ki...> - 2007-07-20 06:47:14
Thu, 19 Jul 2007 22:49:39 -0300
"Felipe Sanches" <felipe.sanches@...> kirjoitti:
> I have implemented the convolve matrix filter
> The patch and the 2 new files have been posted to the patch tracker:
Wow, great. I haven't tested that yet, but looking at the code, it
> I am wondering what is causing the spurious horizontal or vertical
> lines when we scroll the screen. Any clue on that?
Since feConvolveMatrix uses other pixels than the target pixel itself,
you need to implement area_enlarge in the renderer.
That function, given the to-be-rendered area and object
space - screen coordinates transformation matrix, should modify the
area to contain all pixels that are required to correctly render the
See display/nr-filter-gaussian.cpp for an example.
On 7/20/07, Niko Kiirala <niko@...> wrote:
> Wow, great. I haven't tested that yet, but looking at the code, it
> seems fine.
So, Niko, will you please take care of committing this when it's ready?
Thanks a lot Felipe!
Inkscape. Draw Freely.
From: Niko Kiirala <niko@ki...> - 2007-07-20 20:34:27
Fri, 20 Jul 2007 11:13:53 -0400
"bulia byak" <buliabyak@...> kirjoitti:
> So, Niko, will you please take care of committing this when it's
> Thanks a lot Felipe!
Yes, this is now in Inkscape SVN, with a minor modification.
Also, in SVN is now patch for lighting effects, i.e. feDiffuseLighting
and feSpecularLighting. The thanks for these goes to Jean-Ren=E9 Reinhard.
Offtopic: it kind a bugs me that my mails are sponsored by Microsoft...