Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#134 upstream proxy with 'Basic' authentication

pending
Fabian Keil
other (14)
5
2013-09-18
2013-09-18
lsoltero
No

the following patch to proxy 3.0.21 adds upstream proxy authentication of the type

user:password@host:port

sample usage

forward / johndoe:boguspw@upstreamproxy:8000

Discussion

  • Fabian Keil
    Fabian Keil
    2013-09-18

    Thanks a lot for the patch.

    I think the following issues have to be addressed before it can be committed:

    1. It lacks documentation (doc/source/p-config.sgml)
    2. It sends the Basic authentication header unconditionally and doesn't deal with 407 responses which might occur if the proxy uses a different authentication scheme.
    3. The password is hidden for a LOG_LEVEL_CONNECT message but will still be shown when viewing the config file through the CGI interface which by default is available for all Privoxy users while the log file should only be accessible for the Privoxy administrator.
    4. A couple of style issues. strcpy and strpcat shouldn't be used in new code either.
    5. The buffer sizes seem arbitrary (200, 256, 512) and if they aren't sufficient it looks like the token will be silently truncated due to lack of error checking.

    Also note that Privoxy already sort of "supports" Basic authentication by adding a custom header with the pre-computed value.

     
  • Fabian Keil
    Fabian Keil
    2013-09-18

    • summary: patch - upstream proxy with authentication --> upstream proxy with 'Basic' authentication
    • assigned_to: nobody --> fabiankeil
    • milestone: 6576532 -->
    • labels: 103839 --> other
    • status: open --> pending