#575 don't treat blocked redirect as error

future
open
nobody
None
5
2014-07-14
2014-06-17
lvm_
No

After I've enabled some global redirects my log is filling up with "Error: redirect{} overruled by block." messages with no reference to offending redirect or block. In my opinion blocked redirect is a perfectly normal situation, maybe this condition should be logged as a warning if redirect debugging is enabled but I don't think it should be treated as error. 3.0.21

Discussion

  • Fabian Keil
    Fabian Keil
    2014-06-17

    If you are intentionally overruling a previous +redirect{} with a +block{} you can make this obvious by using:

    {-redirect +block{blafasel}}

    You only get the error message if the final results contain both +redirect{} and +block{}. I don't consider this "a perfectly normal situation" as the actions conflict and one has to be ignored.

    Adding -redirect to every +block section doesn't hurt and should silence the error message.

     
  • lvm_
    lvm_
    2014-07-14

    Post awaiting moderation.
  • Fabian Keil
    Fabian Keil
    2014-07-14

    The default.action file is written not to have any
    conflicts between blocks and redirects.

    Given your other request I suspect that you may also
    solve the issue by using path patterns more often.

    The documentation is supposed to mean that Privoxy will
    not honor the redirect, it's not a promise that no error
    message is generated. I just clarified this in cvs.