#52 src: C++ keyword as variable name

3.1
closed-fixed
David Schmidt
None
1
2003-01-21
2002-09-20
Mattes Dolak
No

Hi,

i noticed theres a note in the developers manual stating
that c++ keywords should not be used as variable
names ____
a moment before reading that i noticed the use of
variable "new" (filters.c, function pcrs_filter_response),
which is such an obvious violation of that rule... ;)
i hope someone competent would see about this

_Xoft(o)

Discussion

  • Mattes Dolak
    Mattes Dolak
    2002-09-20

    • priority: 5 --> 1
     
  • Logged In: YES
    user_id=78811

    Thanks for reporting this one. Since there's
    nothing broken, this is a developer-todo rather
    than a bug.

     
    • milestone: 188501 -->
     
  • Mattes Dolak
    Mattes Dolak
    2002-09-22

    Logged In: YES
    user_id=523169

    ufff... i just seem unable to put things in correct categories :P
    i'll improve, i promise ;)

    _Xoft(o)

     
  • David Schmidt
    David Schmidt
    2003-01-21

    • milestone: --> 3.1
    • assigned_to: nobody --> david__schmidt
    • status: open --> closed-fixed
     
  • David Schmidt
    David Schmidt
    2003-01-21

    Logged In: YES
    user_id=249980

    I went through the code and fixed ocurrences of 'new'. I
    also breezed through the code in MSDEV to see if I could
    spot any keywords highlighted. I didn't see anything beyond
    the 'new's, so let me know if you see anything else.