#856 null pointer in log message

version 3.0.19
closed-fixed
Fabian Keil
None
5
2012-03-19
2012-03-17
Matthew Fischer
No

an error message in get_last_url() uses new_url when it is NULL

Discussion

  • patch to use subject instead of new_url

     
    Attachments
  • Fabian Keil
    Fabian Keil
    2012-03-18

    • assigned_to: nobody --> fabiankeil
    • status: open --> pending-fixed
     
  • Fabian Keil
    Fabian Keil
    2012-03-18

    Thanks for the report. Fixed in CVS.

    I take it you discovered the issue through code review/analysis and not by reaching the message while running Privoxy?

    While log_error() should deal with NULL pointers gracefully, the error message in question isn't supposed to be reached in practice. If it is, it would indicate another bug.

     
  • Yes, I noticed it from looking at the code, not from actually running into it.

     
  • Fabian Keil
    Fabian Keil
    2012-03-19

    • status: pending-fixed --> closed-fixed
     
  • Fabian Keil
    Fabian Keil
    2012-03-19

    Thanks for the confirmation.