#887 google filter breaks some pages

pending-fixed
Fabian Keil
5
2012-04-22
2012-04-22
Zeno Kugy
No

It seems that the google filter needs some improvements.
Currently it is disrupting non-ad pages, for example, the page
http://www.bankkonditionen.at/produkte/sparen-anbieter.cfm?sparzinsen=Sparanlage-1-Jahr-gebunden
shows a frame with a chart.
The chart is not shown if the filter is active, because
http://www.google.com/uds/api/visualization/1.0/4da66c523f1d12b8ccaa094c46341418/format+en_GB,default,annotatedtimeline+en_GB.I.js
gets disrupted.
Probably the "</head>" search pattern is too generic.

Discussion

  • Fabian Keil
    Fabian Keil
    2012-04-22

    • assigned_to: nobody --> fabiankeil
    • status: open --> pending-fixed
     
  • Fabian Keil
    Fabian Keil
    2012-04-22

    Thanks for the report. I changed the pattern to "</head>[^\\]".

    Obviously this isn't perfect, so we should probably additionally recommend that the site-specific filters are disabled for "/.*\.js" and maybe "TAG:^application/x-javascript" as well.