Re: [Ieleak-devel] [Ieleak-commit] SF.net SVN: ieleak:[146] trunk/drip/src/DOMReportDlg.cpp
Brought to you by:
matthiasmiller
From: Johan R. <jr...@co...> - 2006-09-14 15:08:52
|
Don't you need a VariantClear(&document) somewhere to avoid memory leaks in Drip? -----Original Message----- From: iel...@li... [mailto:iel...@li...] On Behalf Of Matthias Miller Sent: Thursday, September 14, 2006 4:25 PM To: iel...@li... Subject: Re: [Ieleak-devel] [Ieleak-commit] SF.net SVN: ieleak:[146] trunk/drip/src/DOMReportDlg.cpp Johan, is this what you were thinking? Thanks. -Matthias Miller mat...@us... wrote: > Revision: 146 > http://svn.sourceforge.net/ieleak/?rev=3D146&view=3Drev > Author: matthiasmiller > Date: 2006-09-14 07:13:04 -0700 (Thu, 14 Sep 2006) > > Log Message: > ----------- > workaround to fix crashes on leakDocumentElementTest.htm > > Modified Paths: > -------------- > trunk/drip/src/DOMReportDlg.cpp > > Modified: trunk/drip/src/DOMReportDlg.cpp > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- trunk/drip/src/DOMReportDlg.cpp 2006-09-14 12:51:06 UTC (rev 145) > +++ trunk/drip/src/DOMReportDlg.cpp 2006-09-14 14:13:04 UTC (rev 146) > @@ -147,6 +147,15 @@ > // > node->AddRef(); > m_leaks.push_back(LeakEntry(node, SysAllocString(url), refCount, isRecent)); > + > + // Retrieve a reference to the node's document. Sometimes the node's document is > + // freed but the node retains a pointer to the document, causing crashes when > + // retrieving certain properties. Accessing the document property forces a new, > + // empty document to be created for this node. > + // > + CComQIPtr<IDispatchEx> node_ptr(node); > + VARIANT document; > + (bool)getPropertyValue(node_ptr, L"document", document); > } > =20 > // Clear all leaks. > > > This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. > > ------------------------------------------------------------------------ - > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1= 21642 > _______________________________________________ > Ieleak-commit mailing list > Iel...@li... > https://lists.sourceforge.net/lists/listinfo/ieleak-commit > > > =20 ------------------------------------------------------------------------ - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1= 21642 _______________________________________________ Ieleak-devel mailing list Iel...@li... https://lists.sourceforge.net/lists/listinfo/ieleak-devel *********************************************************************** The information in this message is confidential and may be legally privileged. It is intended solely for the addressee. Access to this=20 message by anyone else is unauthorized. If you are not the=20 intended recipient, any disclosure, copying, or distribution of the=20 message, or any action or omission taken by you in reliance on=20 it is prohibited and may be unlawful. Please immediately contact=20 the sender if you have received this message in error. This email=20 does not constitute any commitment from Cordys Holding BV or=20 any of its subsidiaries except when expressly agreed in a written=20 agreement between the intended recipient and=20 Cordys Holding BV or its subsidiaries. *********************************************************************** |