Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#26 MP3 ReplayGain data in ID3v2 tags not respected

Unstable (example)
open-accepted
nobody
None
5
2014-05-01
2014-05-01
Moonbase
No

IDJC doesn't respect replay-gained MP3 files that have their RG data only in the ID3 tags (i.e., not using APE and/or LAME).

The code in python/playergui.py is basically correct but ignores the fact that Mutagen's EasyID3 class will NOT, per default, read all tags. To read the "TXXX:replaygain_track_gain" tag correctly, the key must be registered with EasyID3 first.

See attached diff.

(We might be calling RegisterTXXXKey unneccessarily often here, maybe the registering could be moved elsewhere?)

1 Attachments

Discussion

  • Registering moved elsewhere. Priority explicitly given to TXXX over RVAD/RVA2 etc.

     
    • status: open --> open-accepted
     
  • Pushed to GIT sources. Please test.

     
  • Moonbase
    Moonbase
    2014-05-01

    Yeah, I will! Thanks for the SUPERFAST response … my whole collection of about 36.000 titles is tagged ID3v2.3-only, so this will be a great help. Cheers!

     
  • Moonbase
    Moonbase
    2014-05-01

    For MP3s, in general, I reckon the priority sequence should be (from lowest to top): 1. LAME tag (might be set by encoder or MP3Gain), 2. RVAD/RVA2, 3. APEv2 (might have been set by MP3Gain), 4. ID3v2 'TXXX:replaygain' tag(s) (because these are almost always added 'manually', i.e. should be preferred over whatever else was set), 5. R128 tags (latest and greatest, and we might* have a situation where users have more than one kind of tag in their files).

    Oh well, just my 2 cents :-) Now off, will be testing the new GIT sources a.s.a.p.

     
  • Moonbase
    Moonbase
    2014-05-01

    Stephen, just re-cloned & compiled, works just great here (ubuntu studio 14.04). Thanks again for your great support!