Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#1 command execution wont work if pathname contains spaces

closed-fixed
None
5
2004-01-13
2003-12-15
Andrej Surkov
No

On my win2000&FB1.0, if pathname, say, TMPPATH
contains spaces then create DB and delete DB wont work.
This applies to every pathname which goes as argument
to any command in php exec() function. Solution:
pathnames have to be quoted. But qoutes must not be
escaped, at least on windows. Diff file attached.

Discussion

  • Andrej Surkov
    Andrej Surkov
    2003-12-15

    fixes create and delete DB

     
    Attachments
  • Andrej Surkov
    Andrej Surkov
    2003-12-15

    • priority: 5 --> 9
    • assigned_to: nobody --> lbrueckner
     
  • Andrej Surkov
    Andrej Surkov
    2003-12-15

    fixes users manipulation with gsec.exe

     
    Attachments
  • Andrej Surkov
    Andrej Surkov
    2003-12-17

    fixes backup, restore etc.

     
    Attachments
  • Andrej Surkov
    Andrej Surkov
    2003-12-17

    all respective diffs

     
    Attachments
  • Andrej Surkov
    Andrej Surkov
    2003-12-17

    Logged In: YES
    user_id=931631

    Some changes made in file 'admin.php' in lines 384 and 387,
    a lack of hostname in restore target string was fixed. Now
    restore should work correctly. Respective changes in diff
    file was made.
    Files 'admin.php' and 'quotes_diffs.txt' was updated.

     
  • Lutz Brueckner
    Lutz Brueckner
    2003-12-21

    • priority: 9 --> 5
     
  • Lutz Brueckner
    Lutz Brueckner
    2003-12-21

    Logged In: YES
    user_id=192077

    Hi Andrej,

    are single quotes also ok with windows? Can you confirm that
    db creation is working with functions.inc.php,v 1.54 which
    I've just comitted to the cvs.

    Thanks, Lutz

     
  • Andrej Surkov
    Andrej Surkov
    2003-12-21

    Logged In: YES
    user_id=931631

    Hi Lutz!

    No, single quotes wont' work. Apache says 'Unable to open
    C:/Program' in its error.log file, while command line is -
    C:\Program Files\Firebird\bin\isql -m -i 'C:/Program
    Files/Apache Group/Apache2/tmp/3fe5dc4f46262.sql'

    Also, as I remember from 'php_manual_en.html' I've read
    pathnames have to be double quoted explisitly. I dont know
    why escapeshellarg() function isnt' updated yet.

    cheers, Andrej

     
  • Lutz Brueckner
    Lutz Brueckner
    2003-12-21

    Logged In: YES
    user_id=192077

    That's really annoying. Could you please make another test
    with functions.inc.php,v 1.55 ?

    Thanks, Lutz

     
  • Andrej Surkov
    Andrej Surkov
    2003-12-21

    Logged In: YES
    user_id=931631

    Lutz,

    will your email me v1.55 of 'functions.inc.php', it seems
    that anonymous cvs repositary wasnt' updated yet.

    Maybe you right and it is annoying, but as a whole I like
    ibWebAdmin much. It differs from phpmyAdmin and its clone
    phppgAdmin in many ways.

    Andrej

     
  • Lutz Brueckner
    Lutz Brueckner
    2004-01-13

    • status: open --> closed-fixed
     
  • Lutz Brueckner
    Lutz Brueckner
    2004-01-13

    Logged In: YES
    user_id=192077

    fixed in cvs and will be released with version 0.94