ping - I'd like to hear from you before I invest some time in creating a patch

On Fri, Dec 7, 2012 at 1:40 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org> wrote:
Hi!

I'd like to work on upstreaming a local change in hyphen library made for Chromium (the open source web browser project behind Google Chrome, see http://chromium.org/).

One change that is needed is to have a function similar to hnj_hyphen_load, but taking a memory buffer instead of a file path. This is needed to use the library inside a sandboxed renderer (the sandbox disallows even read access to the file system; the browser reads the file and effectively passes a descriptor to the renderer process). In case you want to see the code, please take a look at http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/hyphenator/hyphenator.cc?revision=HEAD&view=markup . Even more context can be found at http://code.google.com/p/chromium/issues/detail?id=47083 .

Here is how the patch looks like: http://src.chromium.org/viewvc/chrome/trunk/src/third_party/hyphen/google.patch . It is not directly "upstreamable" because of the HYPHEN_CHROME_CLIENT #ifdefs, but I'd like to ask you how you prefer to do that change, and I can submit a better patch.

Best regards,
Paweł Hajdan, Jr.