Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#206 Memory leak in HashMgr::remove(), remove_forbidden_flag()

open
nobody
None
5
2011-10-03
2011-10-03
Justin Lebar
No

HashMgr::remove() and HashMgr::remove_forbidden_flag both set dp->astr without first freeing it.

Unless I'm missing something pretty basic here, this is a memory leak.

I'd be happy to write a patch, if you'd like. I think the fix is as easy as adding two free() calls.

Discussion

  • Justin Lebar
    Justin Lebar
    2011-10-03

    This patch is untested because we don't end up calling these functions in Mozilla.