[Hugin-cvs] SF.net SVN: hugin: [2159] hugin/branches/ippei/src/hugin_base/hugin_math

[<ip...@us...>]

Revision: 2159
          http://hugin.svn.sourceforge.net/hugin/?rev=2159&view=rev
Author:   ippei
Date:     2007-06-25 10:00:51 -0700 (Mon, 25 Jun 2007)

Log Message:
-----------
tomorrow from hugin_math

Modified Paths:
--------------
    hugin/branches/ippei/src/hugin_base/hugin_math/Matrix3.h
    hugin/branches/ippei/src/hugin_base/hugin_math/Vector3.h
    hugin/branches/ippei/src/hugin_base/hugin_math/math.h

Modified: hugin/branches/ippei/src/hugin_base/hugin_math/Matrix3.h
===================================================================
--- hugin/branches/ippei/src/hugin_base/hugin_math/Matrix3.h	2007-06-25 16:38:25 UTC (rev 2158)
+++ hugin/branches/ippei/src/hugin_base/hugin_math/Matrix3.h	2007-06-25 17:00:51 UTC (rev 2159)
@@ -24,14 +24,15 @@
 #ifndef _HUGIN_MATH_MATRIX3_H_
 #define _HUGIN_MATH_MATRIX3_H_
 
-#include "common/Vector3.h"
+#include "hugin_math/Vector3.h"
 
+// [TODO] methods to a cpp file.
+
 /** general : Matrix3 is a class for handling 3x3 Matrix manipulation.
  *
  * We do not use 4x4 matrix for view point changement as the calculus could be inefficent
  * (some of the coefficients are null, m14 = m24 = m34 = 0 et m44 = 1.0 always).
  */
-
 class Matrix3
 {
 public:
@@ -112,9 +113,10 @@
     }
 #endif 
 
-    // Ippei note: Why the hell is this a method of general Matrix3 class?
+    
+    // [Ippei note]: Why the hell is this a method of general Matrix3 class?
     //  Should be subclassed or externally provided
-    //  eg. static Matrix3 RotationMatrixPT::makeRotationPT(double yaw, double pitch, double roll)
+    //  eg. static Matrix3 RotationMatrixPT::makeRotationMatrixPT(double yaw, double pitch, double roll)
 
     /** set rotation in panotools style, 
      *  code adapted from Panotools-Script by Bruno Postle

Modified: hugin/branches/ippei/src/hugin_base/hugin_math/Vector3.h
===================================================================
--- hugin/branches/ippei/src/hugin_base/hugin_math/Vector3.h	2007-06-25 16:38:25 UTC (rev 2158)
+++ hugin/branches/ippei/src/hugin_base/hugin_math/Vector3.h	2007-06-25 17:00:51 UTC (rev 2159)
@@ -21,6 +21,8 @@
  *
  */
 
+// [TODO] methods to a cpp file
+
 #ifndef _HUGIN_MATH_VECTOR3_H_
 #define _HUGIN_MATH_VECTOR3_H_
 

Modified: hugin/branches/ippei/src/hugin_base/hugin_math/math.h
===================================================================
--- hugin/branches/ippei/src/hugin_base/hugin_math/math.h	2007-06-25 16:38:25 UTC (rev 2158)
+++ hugin/branches/ippei/src/hugin_base/hugin_math/math.h	2007-06-25 17:00:51 UTC (rev 2159)
@@ -50,14 +50,14 @@
 namespace hugin_utils
 {
 
-    inline double round(double x);
+    inline double round(double x); // do we need this?
         
     inline double round(double x)
     {
         return floor(x+0.5);
     }
 
-    inline float roundf(float x);
+    inline float roundf(float x); // do we need this?
 
     inline float roundf(float x)
     {
@@ -74,6 +74,8 @@
         return (int) floor(x);
     }
 
+    
+    
     template <class T>
     inline int roundi(T x)
     {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.