Menu
▾
▴
Re: [HtmlUnit] SF.net SVN: htmlunit:[6374] trunk/htmlunit/src
|
From: Marc G. <mgu...@ya...> - 2011-03-28 07:48:04
|
Hi Ronald, is it possible to build a test case for that? Cheers, Marc. -- HtmlUnit support & consulting from the source Blog: http://mguillem.wordpress.com Le 27/03/2011 12:48, rb...@us... a écrit : > Revision: 6374 > http://htmlunit.svn.sourceforge.net/htmlunit/?rev=6374&view=rev > Author: rbri > Date: 2011-03-27 10:48:30 +0000 (Sun, 27 Mar 2011) > > Log Message: > ----------- > fix for window creation processing > Issue 3247986 > > Modified Paths: > -------------- > trunk/htmlunit/src/changes/changes.xml > trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/DialogWindow.java > trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/TopLevelWindow.java > trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/WebWindowImpl.java > trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/FrameWindow.java > > Modified: trunk/htmlunit/src/changes/changes.xml > =================================================================== > --- trunk/htmlunit/src/changes/changes.xml 2011-03-27 09:08:56 UTC (rev 6373) > +++ trunk/htmlunit/src/changes/changes.xml 2011-03-27 10:48:30 UTC (rev 6374) > @@ -6,6 +6,9 @@ > > <body> > <release version="2.9" date="???" description="Bugfixes"> > +<action type="fix" dev="rbri" issue="3247986" due-to="Kohsuke Kawaguchi"> > + Fix order of steps during Window initialization to avoid NPE in later access. > +</action> > <action type="add" dev="mguillem"> > DefaultCredentialsProvider: reactivate removed addNTLMCredentials and addNTLMProxyCredentials > as HttpClient 4.1 now provides full support for NTLM authentication. > > Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/DialogWindow.java > =================================================================== > --- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/DialogWindow.java 2011-03-27 09:08:56 UTC (rev 6373) > +++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/DialogWindow.java 2011-03-27 10:48:30 UTC (rev 6374) > @@ -34,6 +34,7 @@ > protected DialogWindow(final WebClient webClient, final Object arguments) { > super(webClient); > arguments_ = arguments; > + performRegistration(); > } > > /** > > Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/TopLevelWindow.java > =================================================================== > --- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/TopLevelWindow.java 2011-03-27 09:08:56 UTC (rev 6373) > +++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/TopLevelWindow.java 2011-03-27 10:48:30 UTC (rev 6374) > @@ -45,6 +45,7 @@ > super(webClient); > WebAssert.notNull("name", name); > setName(name); > + performRegistration(); > } > > /** > > Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/WebWindowImpl.java > =================================================================== > --- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/WebWindowImpl.java 2011-03-27 09:08:56 UTC (rev 6373) > +++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/WebWindowImpl.java 2011-03-27 10:48:30 UTC (rev 6374) > @@ -69,7 +69,6 @@ > WebAssert.notNull("webClient", webClient); > webClient_ = webClient; > jobManager_ = new JavaScriptJobManagerImpl(this); > - performRegistration(); > } > > /** > > Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/FrameWindow.java > =================================================================== > --- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/FrameWindow.java 2011-03-27 09:08:56 UTC (rev 6373) > +++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/FrameWindow.java 2011-03-27 10:48:30 UTC (rev 6374) > @@ -39,6 +39,7 @@ > super(frame.getPage().getWebClient()); > frame_ = frame; > final WebWindowImpl parent = (WebWindowImpl) getParentWindow(); > + performRegistration(); > parent.addChildWindow(this); > } > |