#9 Prevent htnotify from looping endlessly

open
nobody
stable (4)
5
2002-08-09
2002-08-09
Anonymous
No

On Solaris 8, with 3.0.4, I have the effect that
htnotify loops
apparently endlessly, eating more and more space.
I tracked it down to htnotify:: readPreAndPostamble()
reading unconfigured prefix and suffix files.
The returned value of config["htnotify_prefix_file"] and
config["htnotify_suffix_file"] is not NULL, but "",
so the loops while (! in.bad() && ! in.eof()) are
entered (why? I don't know. It shouldn't have
opened the "" files in the first place) and keeps
appending '\n' characters without finding an end.
The patch against 3.1.6 fixes that by checking
for "" in addition to NULL.

Discussion

  • htnotify endless loop fix

     
    Attachments
  • Martin Kraemer
    Martin Kraemer
    2002-08-09

    Logged In: YES
    user_id=715

    I forgot to log in. So, for any responses, my name is Martin
    Kraemer
    <martin(at)apache.org>

     
  • Logged In: YES
    user_id=32597

    Your patch works for me.

    In CVS it is fixed here:

    Fri Aug 9 13:01:05 2002 Gilles Detillieux
    <grdetil@scrc.umanitoba.ca>

    * httools/htnotify.cc (readPreAndPostamble): Check for
    empty strings
    in file names, not just NULL, as suggested by Martin Kraemer.

     
  • Logged In: NO

    Your patch works for me.

    In CVS it is fixed here:

    Fri Aug 9 13:01:05 2002 Gilles Detillieux
    <grdetil@scrc.umanitoba.ca>

    * httools/htnotify.cc (readPreAndPostamble): Check for
    empty strings
    in file names, not just NULL, as suggested by Martin Kraemer.