#261 Pages with index bigger than maximum_page_buttons not shown

Include_in_3.2
closed-fixed
htsearch (60)
5
2005-07-20
2005-07-12
Anonymous
No

The problem can be seen on the htdig org website:

1. Enter the word 'link' in the quick search textbox
and press ENTER.
2. Notice that there are more than 3000 hits (more than
300 pages).
3. Click the button to review the 10th page.
4. Notice that there is no way to browse the 11th page
and the rest of pages with index bigger than 10.

Clicking the 10th page, the bottom links should look
something like:

[Previous] 4 5 6 7 8 9 10 11 12 13 14 15 [Next]

My contact info is:

Jose Ortiz
jose@calcugator.com

Discussion

    • milestone: --> 102989
    • assigned_to: nobody --> grdetil
    • status: open --> closed-works-for-me
     
  • Logged In: YES
    user_id=149687

    You're confusing the roles of maximum_page_buttons and
    maximum_pages. The htdig.org website doesn't set either one
    in its config file, so they both default to 10, thus you
    don't get an 11th page.

    See http://www.htdig.org/FAQ.html#q4.19 for details.

    As you're reporting this as a bug in htsearch, and not a
    website bug, I assume you're not objecting to how we
    configured our website, but rather that you thought this was
    an actual bug in htsearch. This issue in htsearch was
    resolved some time ago. If it doesn't work for you on your
    site, it may be that you need to upgrade to 3.1.6 or 3.2.0b6.

     
  • Logged In: NO

    Hi there,

    Thanks for the quick response. Actually, I was not clear
    presenting the problem. Let me try again:

    I installed version 3.2.0b4-20021103.

    In my config file I have the following:

    maximum_pages:100
    maximum_page_buttons:20
    next_page_text: [next]
    no_next_page_text:
    prev_page_text: [prev]
    no_prev_page_text:
    #page_number_text
    #no_page_number_text

    Everything works fine as long as the number of pages found
    is less than 20.

    The problem pops up when the search returns more than 20
    pages, I can't browse pages 21, 22,...

    If I click page 20 I get this line of links:
    [prev] 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20

    I would like to get something like this:
    [prev]5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 [next]

    Is this a bug?

    Jose

     
    • status: closed-works-for-me --> open-works-for-me
     
    • milestone: 102989 --> Include_in_3.2
    • status: open-works-for-me --> open-later
     
  • Logged In: YES
    user_id=149687

    Ah! What you're requesting is Google-style paging, where
    the page number buttons span a number of pages before and
    after the current one. A patch for this is available here:

    http://sourceforge.net/mailarchive/forum.php?thread_id=1377415&forum_id=2688

    for 3.2 betas, and the version for 3.1.6 is here:

    ftp://ftp.ccsf.org/htdig-patches/3.1.6/Google-style.0

    In your e-mail reply to me, you mentioned you had modified
    Display.cc to do this. If your approach to doing this is an
    improvement on Adam Ness's patch, please let us know. I'ld
    be interested in seeing your patch (diff -c3p or diff -u
    format preferred). The reason Adam's patch defines a new
    config attribute to enable this feature (and the reason this
    feature isn't in the code by default) is that Google-style
    floating page links don't work well if you have graphical
    buttons for the page numbers, as the default htdig.conf
    implements -- you'd eventually run out of images for higher
    page numbers.

    We haven't incorporated Adam's patch into the code base yet
    because it's not complete. Adding a new config attribute
    requires making a new entry in htcommon/defaults.cc and
    writing up a good description of how to use the attribute
    (and in this case what to look out for regarding graphical
    page buttons).

     
  • Logged In: YES
    user_id=149687

    Lachlan committed a fix to CVS on June 19, 2004, in response
    to RFE #601177, #600959, #405679, which implements this
    feature. It will come out in the next release, whenever
    that is.

     
    • assigned_to: grdetil --> lha
    • status: open-later --> closed-fixed