From: Jorg S. <Jor...@gm...> - 2007-06-28 13:13:57
|
Michael Tiffany wrote: > On Tue, 2007-06-26 at 00:43 +0900, Jorg Schuler wrote: >> Thanks Michael, thanks Todd for your great work. I've gone through the >> patch and did some minor changes to the "update from track" >> functionality, ironing out some pre-existing (i.e. old) bugs along the way. >> >> I would be grateful if someone could test this patch before submitting >> to SVN -- I'm not exactly into "gapless" :-/ > > Well, I found an instance where this probably does something we don't > want it to, though it won't affect very many people at this point. If > somebody already has gapless information in their iTunesDB (presumably >>from iTunes) for a non-lame file, and then updates from file, gapless > information will not be found, it will be flagged as a change, and the > previous gapless information will be removed. I attached a patch to > file.c to check whether the new gapless information exists or is 0's, > and only updates if it's valid information. At least for now, I assume > we don't want to be overwriting any pre-existing data. > > The patch could really be simplified to just checking to see if the new > gapless_track_flag is true. It maybe should be done this way because if > we get mp4 gapless working, it has a gapless_data of 0 anyway, so the > flag is the easiest/best way to know. Any comments either way, then > I'll put this patch in the trunk and continue work on cleaning up > mp3file in the gapless_playback branch. The patch was not attached, but I'm not sure if that's desired either, as it would make it impossible to correct wrong gapless information, or cases where the original file changed. I'd be inclined to say that if you upgrade a track with gtkpod you get whatever features gtkpod supports. Cheers, JCS. |