Re: [Gtkpod-devel] More work on photo support

[Christophe F. <te...@gn...>]

Le mardi 11 octobre 2005 =C3=A0 00:36 +0200, Flavio Stanchina a =C3=A9crit =
:
> Christophe Fergeau wrote:
> > Jorg added some code to detect the iPod model, [...]
>=20
> Eeeek! (from ipod-device.h)
>=20
> enum {
> 	[...]
> 	MODEL_TYPE_MINI,
> 	MODEL_TYPE_MINI_BLUE,
> 	MODEL_TYPE_MINI_PINK,
> 	MODEL_TYPE_MINI_GREEN,
> 	MODEL_TYPE_MINI_GOLD,
> 	MODEL_TYPE_SHUFFLE,
> 	MODEL_TYPE_NANO_WHITE,
> 	MODEL_TYPE_NANO_BLACK
> };
>=20
> Can we suggest to the libipoddevice guys to have something easier on the
> eyes (and probably on the programmers too), like maybe
>=20
> enum {
> 	[...]
> 	MODEL_TYPE_MINI,
> 	MODEL_TYPE_NANO,
> };
>=20
> enum {
> 	MODEL_FLAVOUR_MINI_BLUE,
> 	MODEL_FLAVOUR_MINI_PINK,
> 	MODEL_FLAVOUR_MINI_GREEN,
> 	MODEL_FLAVOUR_MINI_GOLD,
> 	MODEL_FLAVOUR_MINI_SILVER,
>=20
> 	MODEL_FLAVOUR_NANO_WHITE,
> 	MODEL_FLAVOUR_NANO_BLACK,
> };
>=20

I talked with abock (libipoddevice author) about that on IRC, and he
agreed such a separation would make things a bit nicer, and he seemed to
be willing to accept a patch doing that. I may look at that over the
week-end ....

Christophe