From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-28 00:24:54
|
https://bugzilla.gnome.org/show_bug.cgi?id=635809 gnome-perl | Glib | unspecified Kevin Ryde <user42> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175274|0 |1 is obsolete| | --- Comment #4 from Kevin Ryde <us...@zi...> 2010-11-28 00:24:43 UTC --- Created an attachment (id=175394) View: https://bugzilla.gnome.org/attachment.cgi?id=175394 Review: https://bugzilla.gnome.org/review?bug=635809&attachment=175394 patch Sounds close. I tweaked the comments per attached. Feel free to write something more. The only thing I further wondered was whether a GValue to SV like this might look at the NOCOPY flag, or whatever the public form of that is, and copy if the memory belongs to the GValue or just use the pointer if it belongs to someone else. That might apply generally in a few places, or it might be a bit too subtle, I'm not sure. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |