Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#525 hcache.c:1576: possible missing break ?

Future
closed-fixed
nobody
None
5
2014-07-03
2014-02-07
dcb
No

I just ran the static analysis tool "cppcheck" over the source
code of gtk-gnutella-1.0.0

It said many things, including

[hcache.c:1576] -> [hcache.c:1578]: (warning) Variable 'hc' is reassigned a value before the old one has been used. 'break;' missing?

Source code is

case HOST_GUESS:
    hc = caches[HCACHE_GUESS];
case HOST_GUESS6:
    hc = caches[HCACHE_GUESS6];
    break;

Suggest add missing break

Discussion

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,3 @@
    -
     I just ran the static analysis tool "cppcheck" over the source
     code of gtk-gnutella-1.0.0
    
    • status: open --> pending
    • Group: 0.95 --> Future
     
  • For the record, this bug is already fixed in the "devel" branch.

     
  • Fixed in 1.1.

     
    • status: pending --> closed-fixed