From: Felipe C. <fel...@no...> - 2010-03-08 15:24:36
|
On Sat, Mar 06, 2010 at 07:20:47PM +0100, Rob Clark wrote: > Normally with autotools, you should be able to create a directory outside of the srctree, and then run something like: > > ../path/to/gst-openmax/configure .... > make check install > > but a couple small tweaks were needed to make check work properly. Mainly replacing Makefile with a Makefile.in, and avoiding relative paths to files in the src tree. Minor nitpicks about the commit message: * If there's no submodule prefix, begin the summary with a capital letter. * The summary should be at most 50 characters long, while the rest of the message 80. * If possible, explain in the summary what does the patch *do*, not what it is This ensures that it looks fine across different git tools, and email. Something like: * Fix out-of-tree build * build: fixes for out-of-tree Anyway, I'll fix that and commit. Thanks! -- Felipe Contreras |