From: GStreamer (bugzilla.gnome.org) <bug...@bu...> - 2005-12-21 12:13:58
|
Do not reply to this via email (we are currently unable to handle email responses and they get discarded). You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=3D172419 GStreamer | gst-plugins-ugly | Ver: 0.8.7 ------- Comment #7 from Tim-Philipp M=C3=BCller 2005-12-21 12:13 UTC ---= ---- This still doesn't work right even with Jan's new spiffy id3demux. The ne= w id3demux determines a total tag size of 1682+10=3D1683 and typefinding th= en starts at offset 1683 and fails. If typefinding starts at offset 1684, it= works fine. Not sure if the right fix is something like this if (tag_res =3D=3D ID3TAGS_READ_TAG) { res =3D TRUE; GST_DEBUG_OBJECT (id3demux, "Read ID3v2 tag of size %d", id3demux->strip_start); + id3demux->strip_start =3D GST_ROUND_UP_4 (id3demux->strip_start); } else if (tag_res =3D=3D ID3TAGS_BROKEN_TAG) { res =3D TRUE; GST_WARNING_OBJECT (id3demux, "Ignoring broken ID3v2 tag of size %d"= , id3demux->strip_start); } or if it should skip all zeroes after the tag until it finds a non-zero b= yte and start typefinding on that (is there any ID3-taggable file format that starts with a zero byte?) --=20 Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=3Demail ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |