From: Andy W. <wi...@po...> - 2005-11-29 10:20:46
|
Hi Edgard, This rocks! Nice port. I haven't tried it out yet but the code looks nice. Only a couple comments: On Mon, 2005-11-28 at 18:55 -0800, Edgard Nic=C3=A9as Arcoverde Gusm=C3=A3= o Lima wrote: > +static GstFlowReturn > +gst_mms_create (GstPushSrc * psrc, GstBuffer ** buf) [...] > + *buf =3D gst_buffer_new (); I know this came from the 0.8 version, but you should probably be using either gst_buffer_new_and_alloc or gst_pad_alloc_buffer. If you use alloc_buffer you have to check the flowreturn of course. > + result =3D > + mms_read (NULL, mmssrc->connection, (char *) data, mmssrc->block= size); Normally you would expect a negative result to mean some kind of error. However I looked in the source and this thing can't raise an error. Odd. So this is ok. I guess that's it. Again, nice work :) Cheers, --=20 Andy Wingo http://wingolog.org/ |