#113 ID3v2 unicode support

open
nobody
None
6
2004-08-04
2004-08-04
Vladimir Petrov
No

Unfortunely both two variants of this patch requires to
made changes to id3lib.
ID3v2.3.0 standard tells that allowed encodings are
two: iso-8859-1 or ucs-2. Numeric fields must be in
iso-8859-1. This patch sticks Grip to that requirements.
Both variants of patches adds function
ID3Field_SetEncoding() to c_wrapper.c in the id3lib
library.
I have noticed that ID3Field_SetUNICODE() incorrectly
exchanges the byte order of the data. I am sorry but I
have not big endian machine to test it better.
In one of variants Grip exchanges the byte positions of
the data before sending them to id3lib. In other
variant Grip inserts a BOM character at the begining of
the ucs-2 string and additional fix is made to id3lib
to check whether begins with a BOM symbol.
I have tested this with cyrillic characters by a hex
editor/viewer and a charset convertor, but i cannot
find any mp3 player supporting unicode to test.

I RECCOMEND to use this patch along with patch 1003525.

Discussion

1 2 > >> (Page 1 of 2)
    • priority: 5 --> 6
     
  • Logged In: YES
    user_id=800933

    In version 0.2 one variable name has been changed.
    In version 0.3 one unnecessary memory chunk has been removed.

     
  • Logged In: YES
    user_id=800933

    Here are the patch variants
    grip-3.2.0-id3v2_unicodebom-newframes_woempty-0.1.patch.gz
    grip-3.2.0-id3v2_unicode-newframes_woempty-0.1.patch.gz
    depending to patch
    1013972 Adding more ID3v2 frames
    because their mutual conflictings.

     
1 2 > >> (Page 1 of 2)