#10 Drop Shadows - Patch for 2635032 and 1844937

closed-accepted
Robin Krom
None
5
2010-04-08
2009-02-25
Werner, Wolfgang
No

This is the patch to Issue 2635032. It adds subtle drop shadows to lines, arrows, ellipses and rectangles.

Two screen shots w/ and w/o drop shadows are attached as well.

The user preference to toggle drop shadows requested in 1844937 is not yet implemented but this should be fairly easy.

The patch is in unified format, the patches to all three changed classes are contained in one patch file. If this is inconvenient for you, please let me know.

Discussion

  • Patches

     
    Attachments
  • File Added: original.png

     
  • Some shapes w/o drop shadows, taken w/ 0.7beta

     
    Attachments
  • Similar shapes w/ drop shadows

     
    Attachments
  • File Added: patched.png

     
  • This patch also adds the possibility to toggle drop shadows

     
    Attachments
    • summary: Drop Shadows - Patch for 2635032 and partly 1844937 --> Drop Shadows - Patch for 2635032 and 1844937
     
  • I also added the possibility to toggle the drop shadows on selected shapes.
    The patch is attached but I have actually no idea how to integrate the button image. I used shape_move_forwards.png from the famfamfam silk icon set.

    As I mentioned, I am totally inexperienced in using c# and VS. Please let me know if there is a smarter way to submit patches. I'm pretty confident the first one works out ok. The second one is more complex and contains generated UI code, I'm not sure whether it can be smoothly integrated.

    Totally looking forward to getting feedback.
    File Added: dropShadow2.patch

     
  • Drop shadow toggle button and some shapes w/ and w/o shadows

     
    Attachments
  • File Added: toggleDropShadows.png

     
  • Robin Krom
    Robin Krom
    2010-04-02

    I like the idea, will look at it and see if I can merge this into the 8.x beta. (we changed a lot!!)

    Thank you very much!

    Best wishes,
    Robin

     
  • Robin Krom
    Robin Krom
    2010-04-02

    • assigned_to: nobody --> apex75
     
  • Robin,
    let me know if I can help. The actual code is pretty simple. I'd be very happy to see it in v0.8.

    Best,
    Wolfgang

     
  • Robin Krom
    Robin Krom
    2010-04-08

    Hello Wolfgang,

    We used your code as the base, than we got more changes as suggested in Tracker # 2983930 from Dick Knol who based it upon your code. I think the result looks very nice, I hope you agree.

    Best wishes,
    Robin

     
  • Robin Krom
    Robin Krom
    2010-04-08

    • status: open --> closed-accepted
     
    • status: closed-accepted --> open-accepted
     
  • Hi Robin,

    cool, I just had a look at it, Dicks version definitely looks better than my first version. Also the text shadows are really cool.

    Just one minor suggestion:
    The icon on the button to toggle shadows is not very intuitive. (I know its hard to find a good one)

    Thanks, I really look forward to the release.

     
  • Robin Krom
    Robin Krom
    2010-04-08

    • status: open-accepted --> closed-accepted
     
  • Robin Krom
    Robin Krom
    2010-04-08

    Hello Wolfgang,

    I'm glad you like it! I dislike to change something someone placed a lot of time into it, without making it better.

    About the Icon, there is none.. I just took the one for the "I" as in Italics (Font). I'm not a graphics designer but a coder... One of my other colleagues will make something soon.

    We are working towards the release, trying to fix most small issues we still have and making it look finished... Still have lots of work to do...

    Best wishes,
    Robin