#1 Multiple Display Support

closed-fixed
nobody
None
5
2007-12-02
2007-09-26
Fls'Zen
No

This patch drastically improves support for multiple displays.

Basically, the GetScreenBounds() function is added to MainForm in the capture region. It is a more robust way of determining the bounds of the entire screen area.

This function is used instead of Screen.GetBounds(Cursor.Position) throughout the code. I've replaced the function in init(bool) in MainForm. FlashlightForm has the bound settings moved from the constructor to the Page_Load function. There was some queerness I ran into when trying to set the bounds in the constructor.

Let me know if you have any questions. I haven't tested it with the CVS source, but I don't think there will be a difference. I'll get CVS and patch that if you have problems with the patch.

- James

Discussion

  • Fls'Zen
    Fls'Zen
    2007-09-26

    Diff file of patch.

     
    Attachments
  • Fls'Zen
    Fls'Zen
    2007-09-27

    Fixed Functions

     
    Attachments
  • Fls'Zen
    Fls'Zen
    2007-09-27

    Logged In: YES
    user_id=1189742
    Originator: YES

    I've altered two functions to support screens in configurations where the 2nd display is not to the right of the first. The attachment Fix.txt contains the two replacement functions.
    File Added: Fix.txt

     
  • Jens Klingen
    Jens Klingen
    2007-11-13

    Logged In: YES
    user_id=1855482
    Originator: NO

    Hi James,

    first of all - sorry for not getting back to you earlier... both of us had a lot on our plates lately, thus Greenshot lay more or less idle for some time :-/

    At last, we now have implemented the patch you provided, it works perfectly without any further modification :)

    Great Job - thanks to you, Greenshot will have multi-screen support in version 0.5, which will be released shortly.

    Thanks a lot for helping out with this!

     
  • Jens Klingen
    Jens Klingen
    2007-11-13

    • status: open --> closed-fixed
     
  • Fls'Zen
    Fls'Zen
    2007-11-13

    Logged In: YES
    user_id=1189742
    Originator: YES

    No worries-I understand what it's like to be unable to find time for a project. :-)

     
  • Fls'Zen
    Fls'Zen
    2007-11-13

    • status: closed-fixed --> open-fixed
     
  • Jens Klingen
    Jens Klingen
    2007-12-02

    • status: open-fixed --> closed-fixed
     
  • Jens Klingen
    Jens Klingen
    2007-12-02

    Logged In: YES
    user_id=1855482
    Originator: NO

    Closing this, because this patch has been successfully implemented with release 0.5.

    Thanks.