Re: [Gramps-devel] Localization Selection

[Benny M. <ben...@gm...>]

2011/5/25 Tim Lyons <guy...@gm...>

>
> On May 24, 2011, at 4:02 PM, Jérôme wrote:
>
>  I am working my way through the uses of the locale. I have proposed a fix
>>> for http://www.gramps-project.org/bugs/view.php?id=3866 which also fixes
>>> [3976] and [3977]. This removes all the language processing from Spell.py,
>>> because it is supplied by gtkspell anyway. This means that the locale
>>> processing n Spell.py is no longer necessary.
>>> Jerome and Peter, could you please test my proposed fix for [3866] on
>>> Windows?
>>>
>>
>> I tested it under Linux (GNOME desktop) ...
>> nothing broken and entries are now fixed. :)
>>
>> But you also removed Enchant support,
>>
>
> Yes I did. Enchant was only being used to check if a dictionary was
> present. Enchant was not actually being called direct from Gramps to do the
> spell checking.
>
> Benny, [1] description suggests that enchant should be used as an
> independent package for spell checking, but this doesn't seem to be what the
> code does. The notes in [1] all talk about enchant being used to get a list
> of languages, which is what it does now. I suspect that Gramps and gtkspell
> have both moved on since the bug. I was addressing what is there now.
>
> The whole business in the current Gramps of checking what dictionaries
> could be used, and constructing a list of languages is (IMHO) completely
> pointless. because gtkspell has already checked the dictionaries, and
> constructed a menu of available languages all on its own. Hence the removal
> of all that code.


I did not check spell checking in Gramps recently.
We added enchant because we obtained in the note editor in the context menu
a very long list of languages. With enchant we could avoid this making spell
check practical for people like me with Dutch, Italian, English.

I suspect this will _still_ be the case on my Ubuntu 10.04 box, so we that
we still need this code for support, or at least a check against gtkspell
version.
I'll install the patch and write on the bug report what I find

Benny

>
>
>  and gtkspell under GNOME was always a good association. ;)
>>
>>  Don't understand this.
>
>  We need to also test it under others desktops, like KDE.
>>
>> [1] http://www.gramps-project.org/bugs/view.php?id=2764
>>
>
>