From: Jakim F. <jm...@fr...> - 2011-02-18 21:40:00
|
As part of r16523 the gen.db.write.transaction_commit function has been changed to require a description. So now all of the gramps-addons that use this function are crashing. I discovered it when testing the Census gramplet in Trunk. I checked other gramplets that used transactions, such as the DataEntry gramplet below, and found the same thing. 612777: ERROR: gramps.py: line 142: Unhandled exception Traceback (most recent call last): File "/home/jfriant/.gramps-test/gramps/gramps33/plugins/DataEntryGramplet/DataEntryGramplet.py", line 803, in add_data_entry (_("Gramplet Data Entry: %s") % name_displayer.display(person))) File "/home/jfriant/src/gramps-trunk/src/gen/db/write.py", line 237, in try_ return func(self, *args, **kwargs) File "/home/jfriant/src/gramps-trunk/src/gen/db/write.py", line 1683, in transaction_commit assert transaction.get_description() != '' AssertionError It looks like it can be fixed by adding a message to either transaction_begin or transaction_commit. But since none of the gramps-addons have it yet, I didn't want to start committing changes that aren't appropriate. Should the data entry plugins in gramps-addons be updated to include a message when starting a transaction? -- Jakim <http://friant.org> |