From: Benny M. <ben...@gm...> - 2009-10-30 08:22:41
|
Very good, I applied your old patch yesterday, and all worked fine. I'll undo it, and apply the new patch instead now. What I intend to do is add profile calls, so as to time the different parts on a large datasset, and compare with the old implementation. Based on that, I think I'll probably end up committing this, to then later add improvements as indicated by the profiling. Benny 2009/10/30 Nick Hall <nic...@ho...>: > Benny, > > I've uploaded another patch. (against r13460) > > This contains everything in my working copy except the experimental > place view. > > It contains changes to src/Selectors/_BaseSelector.py and > src/Selectors/_SelectPerson.py in the selector patch. It also contains a > minor change to an import in src/DataViews/PersonView.py which caused a > conflict during a plugin update. > > The changes take into account that the new treebasemodel shares the same > interface and constructor with the flatbasemodel. I have coded it such > that: > > 1. An "if" statement is no longer needed to select between a person and > flat model. > 2. Person model columns are sortable in the selector. > 3. The reverse_order function is used for both types of model. > 4. Any model can define columns to use "exact" rather than "contains" > searching. > > The only 2 patches that should be used now are the last two. I don't > know how to delete files otherwise I would have deleted the old ones. > > Thanks for looking at my patch for the Complete Individual Report. I'll > have a look at it again now. > > Regards, > > Nick. > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > |