Re: [Gramps-devel] question: is EPREFIX, eprefix in _GrampsConfigKeys now obsolete

[James G. S. (jim) <jg...@sa...>]

Raphael Ackermann wrote:
> Jim,
> 
> On Fri, Feb 29, 2008 at 7:40 PM, James G. Sack (jim) <jg...@sa...> wrote:
>> Background: I noticed that r10099 changed eprefix to event_prefix, and
>>  no doubt there were a lot of references updated -- but one got
>>  overlooked in
>>   src/GrampsDbUtils/_GedcomParse.py
>>  which I fixed in r10140 (a minor victory for regression testing, because
>>  I found this by running src/test/gramps_cli_test.py).
>>
>>  The point if this message: I notice there is an eprefix in
>>   src/Config/_GrampsConfigKeys.py
>>  ==> Q: Is it possible this is now obsolete, or is this a different
>>  eprefix.
> 
> It is a different eprefix inasmuch as it the string used in the
> keys.ini file for the preference that is reference in the config as
> Config.EPREFIX and now stored in the dbase as event_prefix.
> 
> --> It doesn't have to be changed, and it is still used and not obsolete.

Ok, thanks for looking into it.

> 
> The reason why I changed eprefix to event_prefix etc is that the
> previously called pprefix could stand for person_prefix or
> place_prefix. The change makes it easier to read the code.
> 
> This change could also be made in the keys.ini file which takes its
> structure from data/gramps.schemas.in
> If it is not a problem to change the config string names in the
> keys.ini file then I could go ahead and change them too.
> 

If I understand correctly, then they are related but not the same. It is
my opinion that names should be different for cases like that so that
people don't get misleading search results, and also so that they go
updating the wrong things in the future. ;-)

Regards,,
..jim