Re: [Gramps-devel] NarrativeWeb, names and bugs

[Benny M. <ben...@gm...>]

It might be obvious, but I need to find it, change it and test it. I don't
code on narrative web, and don't intend to start if I can avoid it.
So, bug list please, even if obvious, so it can be triaged and taken up when
time (read after the critical bugs that destroy your data and eat your
family tree).

Benny

2007/12/13, Eero Tamminen <ee...@us...>:
>
> Hi,
>
> On Monday 10 December 2007, Benny Malengier wrote:
> > I don't code on narritive web, so little to say about the patches.
> > However:
> >
> > 1/please do separate bug issues on the bug tracker. Christmas is coming,
> > you run the risk this gets forgotton
>
> The first bug is obvious in the code (use of wrong variable type):
> ...
>     def display_parent(self, of, handle, title, rel):
> ...
>         if rel != RelLib.ChildRefType.BIRTH:
>             of.write('&nbsp;&nbsp;&nbsp;(%s)' % str(rel))
> ...
>     def display_ind_parents(self,of):
> ...
>                 frel = ""
>                 mrel = ""
> ...
>                         frel = str(child_ref.get_father_relation())
>                         mrel = str(child_ref.get_mother_relation())
> ...
>                     self.display_parent(of,father_handle,_('Father'),frel)
> ...
>                     self.display_parent(of,mother_handle,_('Mother'),mrel)
>
> And trivial to fix (see the patch in earlier mail), so I think it could be
> just fixed right away.
>
>
> The timeline bug I don't care about.  If somebody else sees it still in
> Gramps 3.x, I'll let them handle it (I haven't registered to Gramps BTS
> as I don't use Gramps myself, I'm doing this for a relative who doesn't
> speak english).
>
>
> > 2/order of presentation of events should be as in gramps. If you want it
> > ordered on date, order it on date in gramps. So I do not agree to order
> > it specifically in narrated web
>
> I'm not sure if I understood you correctly.
>
> The events themselves are ordered by dates in the report and that is good.
>
> However, if I change the order for the columns in which the information
> for
> an individual event is presented in Gramps, that doesn't change the event
> presentation in Web report at all (as the report doesn't have any code for
> that).
>
> The individual event information output in Web report doesn't currently
> look
> like in Gramps either because in Gramps it's tabulated and in report it's
> just a single line with non-breaking spaces[1] between the strings. As a
> result, it looks bad.  Putting the description to next row makes the
> output
> much clearer and removes need for localizing for a couple of those
> strings.
>
> [1] Which is also bad because when the strings themselves have spaces,
>      the non-breaking spaces force the break into exactly the wrong place.
>
>
> > Btw. It would be nice if Gramps could have functions for:
> > > - name_before_event(person, event)
> > > - name_after_event(person, event)
> >
> > That would mean a lot of administration. One could give name a timespan
> > eg... Looks like a lot of work to me for little return.
>
> Let's forget it then. :-)
>
>
> > About the sources, true, should not be repeated, however citations
> should
> > be repeated. This is a difficult ballance.
> >
> > Pedigree:
> > > Pretty useless; the same information is already in parents and family
> > > tables, wastes space.  Maybe this could be removed?
> >
> > Now that you mention it.
> >
> > Attached is a patch to disable pedigree and to move sources to the end
> in
> >
> > > the report output:
> > >         Web-sourcesbottom-nopedigree.diff
> >
> > PS. It would be nice if in 3.x the report name would be fixed
> >
> > > from "Narrative" to more correct "Narrated".
> >
> > Done
>
> Thanks!
>
>
>         - Eero
>
>