From: Benny M. <ben...@gm...> - 2013-02-27 16:05:59
|
All, Serge tested removing the lock system from the DB layer. All seems to work, as John indicated it would. He wins 20 min in import time, and off course no error that locks are exhausted. See http://www.gramps-project.org/bugs/view.php?id=6459 Doug, do you need it for gramps-connect? I suppose not as we have the PRIVATE in it. If you guys agree, I would suggest to: 1/add a gramps option to enable locking. Default is no locking 2/based on the option setting, apply the patch of that bug ticket I would suggest an option because officially gramps is a python module, so we should allow other GUI or app to be made that uses multiple threads, and hence needs the locking. Thoughts, ideas? Benny |
From: Doug B. <dou...@gm...> - 2013-02-27 16:41:02
|
On Wed, Feb 27, 2013 at 11:05 AM, Benny Malengier <ben...@gm...> wrote: > All, > > Serge tested removing the lock system from the DB layer. > > All seems to work, as John indicated it would. He wins 20 min in import > time, and off course no error that locks are exhausted. Excellent! > See http://www.gramps-project.org/bugs/view.php?id=6459 > > Doug, do you need it for gramps-connect? I suppose not as we have the > PRIVATE in it. No, I don't anticipate that would be an issue. > If you guys agree, I would suggest to: > > 1/add a gramps option to enable locking. Default is no locking > 2/based on the option setting, apply the patch of that bug ticket > > I would suggest an option because officially gramps is a python module, so > we should allow other GUI or app to be made that uses multiple threads, and > hence needs the locking. > > Thoughts, ideas? That sounds fine to me. I was thinking in any event that import is usually done on an empty database. If a corruption/fail happens, then so what? We are in a state of inconsistent import, and would need to do the import over anyway, so there is no need to rollback. The story is different, of course, if importing into an existing database. But, still left with a database state that we need to rollback to before the import. But if we can get away without locks overall, hurray! -Doug > Benny > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_feb > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > |