I was thinking that maybe we need a new signal, something
like 'modified-filters' or some such. First of all, the
filter menu in the People View would be automatically
updated. Currently the filter editor's close function
explicitly rebuilds that filter menu, but this is suboptimal.
But the main reason is that other places may want to refresh
their filter menus on custom filter changes. These would be:
1. Report dialogs for reports using filters
2. Tools that use filters.
E.g. currently, the event comparison tool offers a filter
selection and the "Launch filter editor" button. After the
filter editor is closed, the menu must be rebuilt. Explicitly
calling this very tool's menu update from the filter editor
is silly, especially so because this tool is a plugin.
If we had a db signal then filter editor would emit it
on any rule's OK and then every interested party would
update if it is connected to that signal. The additional
benefit would be that the changes are instant -- the user
does not need to even close the filter editor to get
So far the even comparison tool was rebuilding its filter menu
on every focus entrance into the menu. I have disabled this,
because every menu rebuild screws up the selected filter,
and it's just too easy to accidentally hover over the filter
Is there any reason why we should add and use such signal?
If not, should we try putting it into 2.0.9?
Alexander Roitman http://www.gramps-project.org