2008/6/30 Craig J. Anderson <ander882@hotmail.com>:
I regret to say that no.  The patch is NOT small.  or at least in my opinion.
And yes.  I would like a review of this report.  That would be excellent.
And I was hoping for a merge into the trunk too (after review).

I have already Emailed the code to Stephane and I started a very simple web site last night and posted the code there (There is probably a LOT better place on gramps-project.org.  So for everyones review, you can obtain the code at:
http://ander882.110mb.com/index.php?p=descendtree3
and sorry for the complete newness of this site...

No problem to send it to Stephane, but the normal way is to do a feature request/bug submission on http://bugs.gramps-project.org/my_view_page.php

Then attach a patch to it, which is the result of svn diff, read http://www.gramps-project.org/wiki/index.php?title=Committing_Policies section on svn diff.
Like this all devels can have a look and have their say, and the author can do changes to the patch as per request.

Benny


thanks.
  Craig A.


Date: Mon, 30 Jun 2008 09:41:15 +0200
From: benny.malengier@gmail.com
To: brian@gramps-project.org
Subject: Re: [Gramps-devel] New version of the Descendant Tree report
CC: stephanecharette@gmail.com; ander882@hotmail.com; gramps-devel@lists.sourceforge.net


I would expect the changes of this patch are small, so after review, if well coded, I'd vote for A, merge with SVN code (branch30).

Benny

2008/6/29 Brian Matherly <brian@gramps-project.org>:
> > There's a Wiki page for such things:
> >
> http://www.gramps-project.org/wiki/index.php?title=Unsupported_Plugins
>
> Do we want to make the Descendant Tree report an
> unsupported plugin?

Reports fall into one of two categories:

Supported:
These plugins are maintained in the official Subversion tree and the Gramps developers will fix bugs against these reports.

Unsupported:
These are any report that is not "Supported". The author of these reports is responsible for maintenance and bug fixes. Many unsupported reports are conveniently listed on the Gramps Wiki so that others can find them.

So, one of two things should happen with this report. Either

A) Someone should merge the changes made by the contributor into SVN - making it supported.

OR

B) Someone should sponsor the plugin and add a link on the Wiki page.

By your offer, I thought you were going for option "B".

~Brian

BTW: Stephane, your Family lines report should be removed from the "Unsupported" page since it is now in SVN.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Gramps-devel mailing list
Gramps-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gramps-devel



Need to know now? Get instant answers with Windows Live Messenger. IM on your terms.