2011/5/7 Nick Hall <nick__hall@hotmail.com>


On 07/05/11 17:25, Gary Burton wrote:
> Hello Devs,
>
> I notice that clicking an event on the person event gramplet opens an event editor window. I think the action should be to open the event reference editor window instead, which is what happens when opening an event from a person editor window. Can anyone think of a reason why I shouldn't make this change?

Good idea.  We should change the family event gramplet as well to make
it consistent.

Should we allow this if the person is already being edited?

Tricky. The answer at the moment is No.
With all these  ways to spawn windows, people would like more freedom however.
The infrastructure is present in the windows to allow it, but the correct signals must be hooked up: monitor change and update data on a change. This is all _very_ complicated however, and people will easily forget to do the correct thing somewhere in the future when a new field is added.

So, in this case, clicking it should open the person editor AND the person eventref editor. After all, eventref does not safe on exit, it stores the changes in the person object that will be saved in the person. I don't think current Gramps allows for this, so we should add a parameter to the init of the person editor to immediately open a subwindow when called. If person in opened already, we could ask the open window (ManagedWindow class can return what the window is), to spawn the correct child window. Will the user find this confusing or not???

Benny



Nick.


> Bye
>
> Gary
>
>
> ------------------------------------------------------------------------------
> WhatsUp Gold - Download Free Network Management Software
> The most intuitive, comprehensive, and cost-effective network
> management toolset available today.  Delivers lowest initial
> acquisition cost and overall TCO of any competing solution.
> http://p.sf.net/sfu/whatsupgold-sd
> _______________________________________________
> Gramps-devel mailing list
> Gramps-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today.  Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Gramps-devel mailing list
Gramps-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gramps-devel