Benny,

This patch looks very unsafe to me.

The variables LOCALE_DIR, IMAGE_DIR, DATA_DIR and DOC_DIR are set by the installer to be the actual installation directories.  After a build but before installation they are set to appropriate locations in the source tree.

Changing them to something else will probably cause an error and will certainly be confusing.  It would be better to fix any bugs in the setup script.

Nick.


On 30/01/13 09:57, Benny Malengier wrote:
John,

Gramps is crashing for me after your patch
http://sourceforge.net/p/gramps/code/21247/

Error:
Traceback (most recent call last):
  File "/home/benny/gramps/branches/maintenance/gramps40/gramps/gui/grampsgui.py", line 338, in __startgramps
    Gramps(argparser)
  File "/home/benny/gramps/branches/maintenance/gramps40/gramps/gui/grampsgui.py", line 257, in __init__
    register_stock_icons()
  File "/home/benny/gramps/branches/maintenance/gramps40/gramps/gui/grampsgui.py", line 208, in register_stock_icons
    base_reg_stock_icons(iconpaths, extraiconsize, items+items_legacy)
  File "/home/benny/gramps/branches/maintenance/gramps40/gramps/gui/pluginmanager.py", line 99, in base_reg_stock_icons
    pixbuf = GdkPixbuf.Pixbuf.new_from_file (ICON)
  File "/usr/lib/python2.7/dist-packages/gi/types.py", line 76, in constructor
    return info.invoke(cls, *args, **kwargs)
GError: Failed to open file '/home/benny/gramps/branches/maintenance/gramps40/gramps/icons/hicolor/gramps.png': No such file or directory

I assume if share is None, then gramps/images mus be used, not icons/hicolor.

For reference, on my PC:
>>> os.environ['XDG_DATA_DIRS']
'/usr/share/kde-plasma:/usr/local/share/:/usr/share/'


Benny


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan


_______________________________________________
Gramps-devel mailing list
Gramps-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gramps-devel