The attached patch fixes the Windows release build, fixes a build
error on RedHat Linux (random() conflict), fixes the ~300 compiler
warnings generated by Visual Studio 6 and 7, and treats warnings as
errors on Windows so that cleanup won't take so long next time :-)
From: Robert Lipe <robertlipe@us...> - 2005-03-18 03:56:46
Andrew Kirmse wrote:
> The attached patch fixes the Windows release build, fixes a build
> error on RedHat Linux (random() conflict), fixes the ~300 compiler
> warnings generated by Visual Studio 6 and 7, and treats warnings as
> errors on Windows so that cleanup won't take so long next time :-)
Thanx for tackling that. That's a pretty timely fix.
You didn't do everything the way I'd have done it, but since I'm
increasingly less likely to actually run through jeeps and pdb
(especially) and actually _fix_ the data types, I'm going to just byte
my tongue and roll over and let them be cast just in the name of getting
if off my todo list. :-)
I've integrated your patch and some other cleanups that caught my eye
while while roaming around the tree.
My worry about promoting warnings to errors is that not all programmers
that want to build on Windows (and I don't know why, but we seem to go
for quarters at a time with nobody doing it and then bursts of activity
like we're seeing right now) actually know how to FIX these things and
get the changes integrated to cure it.
If we had a critical mass of developers watching over the tree as
modules were added, I wouldn't blink an eye at it. Let's try it and
see how it goes.
Please do take a look at what I've done to see if I've captured
everything that's interesting.
Support GPSBabel by helping to improve it or fund those that that have
done so. Visit: