On Sat, Aug 21, 2010 at 1:04 PM, Alex York <alex.york@hotmail.co.uk> wrote:

Was I mistaken about reference/memory-map.mmo being marked as an ASCII file in the repository?

No.  I just hadn't had time to address it  until now.   Done.

I tried running the testo script and it fails for a large number of formats so I suspect that this issue affects other reference files as well.

If you could provide a list, I'll tweak them in the repository. 

I have been adding support for Memory Map files with an internal version number of 24 to mmo.c . I notice that the code currently supports reading internal versions 17, 18 and 22 but there is only a single test file, reference/memory-map.mmo , with an internal version of 22. Is the policy to only have a single reference file for a given format regardless of the number of variants read or would it be reasonable to add another file named reference/memory-map-v24.mmo

In fantasy land, we'd have 100% code coverage for every version of all these files.   It's been our experience that most of them differ so trivially that's it's not historically been worth it, but it's good practice.  So if you have test files for more versions that trigger different code paths, please feel free to submit those with your patch.
and add appropriate additonal tests to testo.d/classic-4.test ?

As I've touched classic-*.test, I've been busting them into standalone files.  That allows you to run the tests individually, e.g. 'testo kml'.