From: <mar...@us...> - 2013-06-28 06:22:23
|
Revision: 14457 http://sourceforge.net/p/gphoto/code/14457 Author: marcusmeissner Date: 2013-06-28 06:22:17 +0000 (Fri, 28 Jun 2013) Log Message: ----------- wrong sizeof (Coverity) Modified Paths: -------------- trunk/libgphoto2/camlibs/sierra/sierra-usbwrap.c Modified: trunk/libgphoto2/camlibs/sierra/sierra-usbwrap.c =================================================================== --- trunk/libgphoto2/camlibs/sierra/sierra-usbwrap.c 2013-06-27 19:22:58 UTC (rev 14456) +++ trunk/libgphoto2/camlibs/sierra/sierra-usbwrap.c 2013-06-28 06:22:17 UTC (rev 14457) @@ -356,12 +356,12 @@ } *sierra_len = msg_len - sizeof(*msg); - msg = (uw_pkout_sierra_hdr_t*)malloc(msg_len); + msg = (uw_pkout_sierra_hdr_t*)calloc(msg_len,1); + memset(&cmd, 0, sizeof(cmd)); cmd.cmd = cmdbyte(type, 2); cmd.length = uw_value(msg_len); - memset(msg, 0, sizeof(msg)); ret = gp_port_send_scsi_cmd (dev, 0, (char*)&cmd, sizeof(cmd), sense_buffer, sizeof(sense_buffer), (char*)msg, msg_len); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |