Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#583 doc2texi patch to avoid duplicate info nodes

closed-accepted
nobody
None
5
2012-04-26
2012-04-25
Jon Oddie
No

Two minor bugfixes for doc2texi.el (the documentation -> texinfo converter):

- clearer code for determining which term files to read in `d2t-get-terminals`. Avoids adding the same terminal file as an Info node more than once, which could happen before on some systems.

- fix code for uniquifying duplicate node names; won't fail if more than two nodes have the same name, although that shouldn't happen any more

Discussion

  • Ethan Merritt
    Ethan Merritt
    2012-04-26

    When I apply this patch and do "make gnuplot.texi" I get the following error:

    [344] make gnuplot.texi
    Creating texinfo
    Loading /etc/emacs/site-start.d/autoconf.el (source)...
    Loading /etc/emacs/site-start.d/cmake.el (source)...
    Loading /etc/emacs/site-start.d/desktop-file-utils.el (source)...
    Loading /etc/emacs/site-start.d/gettext.el (source)...
    Loading /etc/emacs/site-start.d/python.el (source)...
    Loading /etc/emacs/site-start.d/rpm-mandriva-setup.el (source)...
    Loading /etc/emacs/site-start.d/rst.el (source)...
    Loading /etc/emacs/site-start.d/ruby.el (source)...
    Loading /etc/emacs/site-start.d/vc_git.el (source)...
    Inserting help for terminals ...
    Wrong type argument: stringp, ("linux")
    make: *** [gnuplot.texi] Error 255

    [345] emacs --version
    GNU Emacs 23.1.1

    Before applying the patch, gnuplot.texi was generated with no error, so this problem was introduced by something in the patch.

     
  • Jon Oddie
    Jon Oddie
    2012-04-26

    Context diff, take 2

     
  • Jon Oddie
    Jon Oddie
    2012-04-26

    There was a dumb bug in my original patch which did not appear on my system.

    It should hopefully be fixed in the new version (doc2texi-bugfix-patch-2.diff) just uploaded.

     
  • Ethan Merritt
    Ethan Merritt
    2012-04-26

    • status: open --> closed-accepted