Re: Want to contribute in gnuplot

[Ethan A M. <sf...@us...>]

On Sunday, April 22, 2012 01:31:54 pm Aman (neshu) Agarwal wrote:
> I installed the x11-devel library using yum and it start working :D
> 
> Apart from that I need a small favour from you guys actually, I wrote a
> small patch on
> http://sourceforge.net/mailarchive/forum.php?thread_name=Pine.LNX.4.64.1006132254080.2528%40tesla&forum_name=gnuplot-beta
> 
>  and I am asking you for the guideline and process for submitting the patch
> in gnuplot.PFA of current patch related to the story and kindly 

It is better to submit patches using the Tracker system at
   https://sourceforge.net/tracker/?group_id=2055&atid=302055
Patches attached to Email can get lost or forgotten, and it is not so
obvious how to find out if there is an updated version.

It is not strictly necessary, but it would be useful to also provide
a test case or example script that demonstrates the new feature.
If the patch corrects a weakness in the existing code, either an
actual bug or just a non-optimal behaviour, it would be good to 
provide an example that fails on the CVS code but works (or works
better) after applying your patch.

> suggest me the changes  I need to made.

coding style:

1) If the new routine quantize_tics() is used only in axis.c, it should
be declared as static and a prototype declaration should be added at the
head of the file.  If it is called from other places, the prototype
declaration should be placed instead in axis.h.

2) FLT_EPSILON is not guaranteed to be defined. If you really need this,
then the code defining MACHEPS that is currently in specfun.c should be
moved to specfun.h so that other files can share it.

3) It is not necessary to modify the date in version.c.
The build script will fill that in automatically.


	Ethan