From: Michael G. <mic...@gm...> - 2008-04-11 05:31:59
|
On Thu, Apr 10, 2008 at 11:42 PM, Petr Mikulik <mi...@ph...> wrote: > Your patch for gnuplot > [ 1627936 ] Gnuplot Win32 in console mode > http://sourceforge.net/tracker/index.php?func=detail&aid=1627936&group_id=2055&atid=302055 > is dated Janury 2007. > > From the above, it seems you maintain your patch somewhere inside the octave > forge cvs tree. Hm, it has taken me long clicking to find it at > http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/admin/Windows/msvc/libs/gnuplot-4.2.2.diff?view=annotate > > (I have no idea how this patch can be useful as this patch is not inside the > package windows-1.0.4.tar.gz, but that's an Octave-forge problem.) This is a packaging issue. I use the patch to generate a working Win32 gnuplot version that is bundled with the octave binary package. > From previous mails from Tatsuro MATSUOKA, I've got an impression the patch > you maintain is for gnuplot 4.3 because of the "refresh" command, but it's > actually for 4.2.2, right? I've tried it, and there are rejects for both > 4.3cvs and 4.2.3. It's only for 4.2.2. I didn't try with more recent versions. I stick with stable releases for all packages I compile. > In order to propagate your work into the gnuplot source code, I propose: > > - you move the work on the patch to gnuplot's Patches: > [ 1627936 ] Gnuplot Win32 in console mode > > - do you prefer to work on the patch for 4.2.3 or for 4.3cvs? > > - you should split the patch into three independent parts: > - the wxt-MSW patches -- to be discussed with the authors of wx > terminal, put into cvs independently > - the OCTAVE_BUILD default settings -- another way how to set > its defaults should be found > - the core of your patch > > - please add patches to makefile.mgw so that others can compile it by the > MingW compiler I'll try to address these later. I'm quite busy for the moment and I don't have that much time. > - after reading some mails and the patch description in #1627936, I wonder > whether it is console or console-less version? I.e., does it look like the > OS/2 or Unixish gnuplot when you run it? (You can enter commands via > readline from the command console, and stdin piping works too.) > Or is there no console (nor textual nor graphical) and commands can go > only from stdin? It's a real console version: you get a DOS prompt where you can enter commands. In that sense, it works like the OS/2 or UNIX versions. > - If it is a pipe-only wgnuplot, then it should be really called "pgnuplot", > not gnuplot. [snip] > And also other Windows programs using gnuplot drawing engine expect > pgnuplot.exe, so let's keep the name. In my patch I used pgnuplot for the console version I developed, and renamed the old pipe-to-wgnuplot to pgnuplot_win. So you end up with 3 programs: wgnuplot, pgnuplot_win and pgnuplot. This is probably not the optimal way to do it. Michael. |